Add pointer warping on wayland #112287
Add pointer warping on wayland #112287
Conversation
|
It seems the commit hash in I just copied the pointer warp xml file from the main branch, should i include the one from 1.45 if its different? |
Yea, as wayland-protocols is at that version. If the protocol is not available there feel free to make a PR updating it.
Nah, it's done in only two places now and it's something that we should generally not do, as pointed out by the big comment.
Not sure tbh. I'll be fair, in these cases I just keep them there, duplicated. You never know if the other half will be there by the time you'll need to read that comment again :P |
Kiisu-Master
force-pushed
the
wl_pointer_warp
branch
2 times, most recently
from
e95791a to
1d153b6
Compare
| return; | ||
| } | ||
|
|
||
| struct wl_surface *surface = window_get_wl_surface(p_ss->pointer_data.last_pointed_id); |
There was a problem hiding this comment.
Whats the difference between last_pointed_id and pointed_id? I just noticed back in pointer_warp it uses pointed_id to get the window...
There was a problem hiding this comment.
Hmm doesn't seem to make a difference. Ill just make it use pointed_id here too.
There was a problem hiding this comment.
pointed_id is the current pointed window. It will be set to INVALID_WINDOW_ID, while last_pointed_id never gets cleared.
Kiisu-Master
force-pushed
the
wl_pointer_warp
branch
2 times, most recently
from
8850dc3 to
89faf8f
Compare
Kiisu-Master
force-pushed
the
wl_pointer_warp
branch
from
89faf8f to
9f8a4ef
Compare
|
I keep forgetting to add changed files before committing |
Kiisu-Master
force-pushed
the
wl_pointer_warp
branch
from
9f8a4ef to
1500375
Compare
|
This is not working at all on my end: Fedora Kinoite 42 / KDE Plasma 6.5.1 |
|
How did you test it? Heres a test project i made for this: |
There was a problem hiding this comment.
Oh, I see. I had prefer_wayland enabled and forgot that it's an editor setting. It works now.
CC @bruvzg to check the code.
|
|
||
| if (name == registry->wp_pointer_warp_name) { | ||
| if (registry->wp_pointer_warp) { | ||
| wp_pointer_warp_v1_destroy(registry->wp_pointer_warp); |
There was a problem hiding this comment.
Don't forget to also destroy it WaylandThread::destroy().
There was a problem hiding this comment.
I don't understand what you mean
There was a problem hiding this comment.
Ah, you have to destroy it there too? I'll add this tomorrow
There was a problem hiding this comment.
Yea it's kinda annoying. I've considered making it automatic but I feel like it would make everything more complex for little gain.
4 participants
fixes #64296
Note: I have no idea if how i did things is correct, this is my second time working with c++ and godot source.
I just tried to follow how things were done in the surrounding code.
Tested on latest kwin plasma 6.5.1